<p>This might look too magic, but what it does in short:</p>
<ul>
<li>Replace <code>/usr/bin/env foo</code> with <code>/usr/bin/foo</code>.. One could argue on this, so we could add some macro to disable this. In Fedora it is even prohibited by guidelines now. This brp would help a lot!</li>
<li>Drop shebang from non-executable files.. Having shebangs in non-executable files doesn't make sense to me. If you think I'm wrong, I'm ready to listen!</li>
<li>If shebang is empty or doesn't exist, but file is executable - remove executable bit, most likely it will not work anyway, only by luck</li>
<li>Error out on shebangs like <code>#!perl</code>, this works only by luck</li>
</ul>
<p>cc <a href="https://github.com/jasontibbitts" class="user-mention">@jasontibbitts</a> <a href="https://github.com/conan-kudo" class="user-mention">@Conan-Kudo</a></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/344#issuecomment-341269384">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ANb80_VV370ihBiQvUR4kSuLuKXQsGVqks5syPlIgaJpZM4QO8ad">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ANb80yAakhjG0nkA5jBLASHS4to6lHIcks5syPlIgaJpZM4QO8ad.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/rpm-software-management/rpm/pull/344#issuecomment-341269384"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/rpm-software-management/rpm","title":"rpm-software-management/rpm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/rpm-software-management/rpm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ignatenkobrain in #344: This might look too magic, but what it does in short:\r\n\r\n* Replace `/usr/bin/env foo` with `/usr/bin/foo`.. One could argue on this, so we could add some macro to disable this. In Fedora it is even prohibited by guidelines now. This brp would help a lot!\r\n* Drop shebang from non-executable files.. Having shebangs in non-executable files doesn't make sense to me. If you think I'm wrong, I'm ready to listen!\r\n* If shebang is empty or doesn't exist, but file is executable - remove executable bit, most likely it will not work anyway, only by luck\r\n* Error out on shebangs like `#!perl`, this works only by luck\r\n\r\ncc @jasontibbitts @Conan-Kudo "}],"action":{"name":"View Pull Request","url":"https://github.com/rpm-software-management/rpm/pull/344#issuecomment-341269384"}}}</script>