<p>I think it might be actually better to just not export posix.ctermid() on systems that don't support it. I don't see much good coming out of claiming the controlling terminal is /dev/tty on a system that doesn't have terminals at all.</p>
<p>And yeah a bit of rationale as for the why part is in order, because ctermid() is mandated by POSIX.1-2001 and POSIX.1-2008.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/345#issuecomment-341646146">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ANb80z7v8N-EY_6vVUdEH3va6ud3mXSbks5sytFJgaJpZM4QP28z">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ANb8005DQOeNxUQa5W_kMJROGZAHzl-4ks5sytFJgaJpZM4QP28z.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/rpm-software-management/rpm/pull/345#issuecomment-341646146"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/rpm-software-management/rpm","title":"rpm-software-management/rpm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/rpm-software-management/rpm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@pmatilai in #345: I think it might be actually better to just not export posix.ctermid() on systems that don't support it. I don't see much good coming out of claiming the controlling terminal is /dev/tty on a system that doesn't have terminals at all.\r\n\r\nAnd yeah a bit of rationale as for the why part is in order, because ctermid() is mandated by POSIX.1-2001 and POSIX.1-2008."}],"action":{"name":"View Pull Request","url":"https://github.com/rpm-software-management/rpm/pull/345#issuecomment-341646146"}}}</script>