<p>The old code just subtracted 8 bytes from the reserved space, but<br>
that does not take tag alignment into account and led to the<br>
signature header overwriting the package header.</p>
<p>We now use headerSizeof to calculate the real size difference.</p>
<p>Note that this only works reliable if the reserved space tag comes<br>
last in the signature header!</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/rpm-software-management/rpm/pull/379'>https://github.com/rpm-software-management/rpm/pull/379</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Fix sigheader generation for big archives</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/rpm-software-management/rpm/pull/379/files#diff-0">lib/signature.c</a>
    (43)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/rpm-software-management/rpm/pull/379.patch'>https://github.com/rpm-software-management/rpm/pull/379.patch</a></li>
  <li><a href='https://github.com/rpm-software-management/rpm/pull/379.diff'>https://github.com/rpm-software-management/rpm/pull/379.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/379">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ANb804wWmk7OCN0l_jluA1FLLDWJIzzSks5tHhhHgaJpZM4RUZjl">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ANb805LC0rAXHinZqNXhi99B7-LXA1UFks5tHhhHgaJpZM4RUZjl.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/rpm-software-management/rpm/pull/379"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/rpm-software-management/rpm","title":"rpm-software-management/rpm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/rpm-software-management/rpm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Fix sigheader generation for big archives (#379)"}],"action":{"name":"View Pull Request","url":"https://github.com/rpm-software-management/rpm/pull/379"}}}</script>