<p>First issue is that doUntar() when encounters an issue related to the<br>
spec file, returns non-NULL which indicates that no error has happened.<br>
Second is that even if it would return that, parsePrep() is simply<br>
ignores return code.</p>
<p>Also be more consistent with "goto exit;".</p>
<p>Fixes: <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/rpm-software-management/rpm/commit/76c429c3178c965c6517629957a633768132904c/hovercard" href="https://github.com/rpm-software-management/rpm/commit/76c429c3178c965c6517629957a633768132904c"><tt>76c429c</tt></a><br>
Fixes: <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/rpm-software-management/rpm/commit/c7a8c1e079d2a166b9848ae6afa1b0cfab1b250a/hovercard" href="https://github.com/rpm-software-management/rpm/commit/c7a8c1e079d2a166b9848ae6afa1b0cfab1b250a"><tt>c7a8c1e</tt></a><br>
<span class="issue-keyword tooltipped tooltipped-se" aria-label="This pull request closes issue #728.">Fixes</span>: <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="451201976" data-permission-text="Issue title is private" data-url="https://github.com/rpm-software-management/rpm/issues/728" data-hovercard-type="issue" data-hovercard-url="/rpm-software-management/rpm/issues/728/hovercard" href="https://github.com/rpm-software-management/rpm/issues/728">#728</a><br>
Signed-off-by: Igor Gnatenko <a href="mailto:i.gnatenko.brain@gmail.com">i.gnatenko.brain@gmail.com</a></p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/rpm-software-management/rpm/pull/730'>https://github.com/rpm-software-management/rpm/pull/730</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Stop immediately if there is a problem with Source</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/rpm-software-management/rpm/pull/730/files#diff-0">build/parsePrep.c</a>
    (13)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/rpm-software-management/rpm/pull/730.patch'>https://github.com/rpm-software-management/rpm/pull/730.patch</a></li>
  <li><a href='https://github.com/rpm-software-management/rpm/pull/730.diff'>https://github.com/rpm-software-management/rpm/pull/730.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/730?email_source=notifications&email_token=ADLPZU3S3EVPHOILBG2J73LPYQBQVA5CNFSM4HSDEVA2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GXFAP6A">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ADLPZUYM5AIN7QVVOYIOGM3PYQBQVANCNFSM4HSDEVAQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/ADLPZUZJWFNM7QPZ6QXSLWLPYQBQVA5CNFSM4HSDEVA2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GXFAP6A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/rpm-software-management/rpm/pull/730?email_source=notifications\u0026email_token=ADLPZU3S3EVPHOILBG2J73LPYQBQVA5CNFSM4HSDEVA2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GXFAP6A",
"url": "https://github.com/rpm-software-management/rpm/pull/730?email_source=notifications\u0026email_token=ADLPZU3S3EVPHOILBG2J73LPYQBQVA5CNFSM4HSDEVA2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GXFAP6A",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>