<p><b>@pmatilai</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/rpm-software-management/rpm/pull/729#discussion_r289815226">build/rpmfc.c</a>:</p>
<pre style='color:#555'>> @@ -444,17 +444,12 @@ int rpmfcExec(ARGV_const_t av, StringBuf sb_stdin, StringBuf * sb_stdoutp,
     }
     ec = getOutputFrom(xav, buf_stdin, buf_stdin_len, sb,
                       failnonzero, buildRoot, dup);
-    if (ec) {
-       sb = freeStringBuf(sb);
-    }
</pre>
<p>What I think is that this whole move to rpmfcExec() has started increasingly  feeling like a mistake. <g-emoji class="g-emoji" alias="grimacing" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f62c.png">😬</g-emoji> But it's a bit late to revert, that'd be a huge mess too.</p>
<p>I agree lets just leave it the way it is for now.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/729?email_source=notifications&email_token=ADLPZUZEFECXTRFR2LIH6CDPYUDVNA5CNFSM4HSDAKWKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2L7XTQ#discussion_r289815226">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ADLPZUYDYZJHWJLNO3BJNSTPYUDVNANCNFSM4HSDAKWA">mute the thread</a>.<img src="https://github.com/notifications/beacon/ADLPZU4U6BKMGKPOBY7SNXLPYUDVNA5CNFSM4HSDAKWKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2L7XTQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/rpm-software-management/rpm/pull/729?email_source=notifications\u0026email_token=ADLPZUZEFECXTRFR2LIH6CDPYUDVNA5CNFSM4HSDAKWKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2L7XTQ#discussion_r289815226",
"url": "https://github.com/rpm-software-management/rpm/pull/729?email_source=notifications\u0026email_token=ADLPZUZEFECXTRFR2LIH6CDPYUDVNA5CNFSM4HSDAKWKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2L7XTQ#discussion_r289815226",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>