<p><b>@ignatenkobrain</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/rpm-software-management/rpm/pull/729#discussion_r289812788">build/rpmfc.c</a>:</p>
<pre style='color:#555'>> @@ -444,17 +444,12 @@ int rpmfcExec(ARGV_const_t av, StringBuf sb_stdin, StringBuf * sb_stdoutp,
     }
     ec = getOutputFrom(xav, buf_stdin, buf_stdin_len, sb,
                       failnonzero, buildRoot, dup);
-    if (ec) {
-       sb = freeStringBuf(sb);
-    }
</pre>
<p>to be honest, I just felt weird that it was freed when failnonzero.. I did not have any specific case why I wanted it to be different.</p>
<p>SO I suppose if we change behavior, we should change behavior of return code because now it is just 0 - ok, 1 - fail. while in some cases you want to get actual return code.</p>
<p>So I propose to merge it without behavior change so we don't have to fix anything else on the way. And when we decide to change behavior, then we will look at it again.</p>
<p>WDYT?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/729?email_source=notifications&email_token=ADLPZU6MUCOZ2747QJIPYFLPYUC4JA5CNFSM4HSDAKWKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2L675Q#discussion_r289812788">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ADLPZU6CRYAV3KIMIPQ37XDPYUC4JANCNFSM4HSDAKWA">mute the thread</a>.<img src="https://github.com/notifications/beacon/ADLPZU4ZE6MND7F7UB6WPKDPYUC4JA5CNFSM4HSDAKWKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2L675Q.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/rpm-software-management/rpm/pull/729?email_source=notifications\u0026email_token=ADLPZU6MUCOZ2747QJIPYFLPYUC4JA5CNFSM4HSDAKWKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2L675Q#discussion_r289812788",
"url": "https://github.com/rpm-software-management/rpm/pull/729?email_source=notifications\u0026email_token=ADLPZU6MUCOZ2747QJIPYFLPYUC4JA5CNFSM4HSDAKWKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2L675Q#discussion_r289812788",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>