<p><b>@pmatilai</b> commented on this pull request.</p>

<p>It might be implemented internally in bash, but generally speaking "[" is an external command (try 'ls -l /bin/[') and needs to be surrounded by space, and even in bash it's common good style anyway (see elsewhere in the script). Shell coding style differs from that of C...</p>
<p>For the same externality reason (ie to avoid fork+exec), the [ command implements it's own and-operator as -a switch, which is commonly used in find-debuginfo.sh instead of &&, but that's strictly optional as find-debuginfo is a bash script.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/737?email_source=notifications&email_token=ADLPZU577BZSLM3UEDXMAHDPY5N6LA5CNFSM4HTOX7QKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2TQ3DI#pullrequestreview-245829005">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ADLPZU7OJ27E7P2WICI5TALPY5N6LANCNFSM4HTOX7QA">mute the thread</a>.<img src="https://github.com/notifications/beacon/ADLPZU345WQUKL3EEE4W37DPY5N6LA5CNFSM4HTOX7QKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2TQ3DI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/rpm-software-management/rpm/pull/737?email_source=notifications\u0026email_token=ADLPZU577BZSLM3UEDXMAHDPY5N6LA5CNFSM4HTOX7QKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2TQ3DI#pullrequestreview-245829005",
"url": "https://github.com/rpm-software-management/rpm/pull/737?email_source=notifications\u0026email_token=ADLPZU577BZSLM3UEDXMAHDPY5N6LA5CNFSM4HTOX7QKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2TQ3DI#pullrequestreview-245829005",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>