<p><b>@pmatilai</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/rpm-software-management/rpm/pull/739#discussion_r291094565">build/parseChangelog.c</a>:</p>
<pre style='color:#555'>> @@ -130,8 +130,7 @@ static int dateToTimet(const char * datestr, time_t * secs, int * date_words)
        SKIPNONSPACE(pe);
        if (*pe != '\0')
           *pe++ = '\0';
-       if (((int)(pe-p) + 1) > 9 )
-          goto exit;
+       tz_name = xmalloc((int)(pe-p)+1);
        strncpy(tz_name, p, (int)(pe-p));
        tz_name[(int)(pe-p)] = '\0';
</pre>
<p>The same pe-p calculation is done several times here with cases and all. Use a helper variable in a case like this.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/739?email_source=notifications&email_token=ADLPZUYEMRANSIAA5GM7RODPZDJZXA5CNFSM4HTUSY7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2YJVHI#pullrequestreview-246454941">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ADLPZU5FBFTW4IIL3BFDOKLPZDJZXANCNFSM4HTUSY7A">mute the thread</a>.<img src="https://github.com/notifications/beacon/ADLPZU2NQNTC6C4HXLBWDHLPZDJZXA5CNFSM4HTUSY7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2YJVHI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/rpm-software-management/rpm/pull/739?email_source=notifications\u0026email_token=ADLPZUYEMRANSIAA5GM7RODPZDJZXA5CNFSM4HTUSY7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2YJVHI#pullrequestreview-246454941",
"url": "https://github.com/rpm-software-management/rpm/pull/739?email_source=notifications\u0026email_token=ADLPZUYEMRANSIAA5GM7RODPZDJZXA5CNFSM4HTUSY7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2YJVHI#pullrequestreview-246454941",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>