<p>We always allocate the index here as should be obvious from the code,<br>
the condition is a leftover that might've been relevant in the turn<br>
of the millenium but not anymore.</p>
<p>This construct confused clang into thinking there's a NULL pointer<br>
dereference at the end of a long callchain (maybe because the indexlen<br>
argument is signed so if you passed in -1 as indexLen... but fixing<br>
those int32_t's is another story)</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/rpm-software-management/rpm/pull/748'>https://github.com/rpm-software-management/rpm/pull/748</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Drop bogus condition from header index allocation</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/rpm-software-management/rpm/pull/748/files#diff-0">lib/header.c</a>
    (5)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/rpm-software-management/rpm/pull/748.patch'>https://github.com/rpm-software-management/rpm/pull/748.patch</a></li>
  <li><a href='https://github.com/rpm-software-management/rpm/pull/748.diff'>https://github.com/rpm-software-management/rpm/pull/748.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/748?email_source=notifications&email_token=ADLPZU4Z3MKUJULJRFCZ7ODP2IIHTA5CNFSM4HXXWYCKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GZIOW4Q">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ADLPZU23IKXYYCXPDF7QGMDP2IIHTANCNFSM4HXXWYCA">mute the thread</a>.<img src="https://github.com/notifications/beacon/ADLPZU5MVIYPZP7AZ24F4DLP2IIHTA5CNFSM4HXXWYCKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GZIOW4Q.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/rpm-software-management/rpm/pull/748?email_source=notifications\u0026email_token=ADLPZU4Z3MKUJULJRFCZ7ODP2IIHTA5CNFSM4HXXWYCKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GZIOW4Q",
"url": "https://github.com/rpm-software-management/rpm/pull/748?email_source=notifications\u0026email_token=ADLPZU4Z3MKUJULJRFCZ7ODP2IIHTA5CNFSM4HXXWYCKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GZIOW4Q",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>