Hi Colin,<br>
<br>
> Can you keep the commit message title to < 80 chars? And move the text from the PR description into the commit message as well.<br>
<br>
Sorry about that, I will remember for next time.<br>
<br>
> Seems OK to me but: why don't the compilers do this by default?<br>
<br>
Because at the time that the notes are created it is not possible<br>
to determine which ones will actually be needed in the final executable.<br>
(This is because of things like link-once sections, hot/cold partitioning<br>
and so on).  The duplicate-eliminating and note-combining steps performed<br>
by "objcopy --merge-notes" could in theory be performed by the linker, but<br>
this has the problem that there are three linkers (ld.bfd, ld.gold, lld)<br>
which would need to be modified, potentially introducing a lot more bugs.<br>
Plus by putting the code into objcopy it means that binaries produced by<br>
older linkers can still be processed.<br>
<br>
Cheers<br>
  Nick<br>
<br>
<br>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you commented.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/751?email_source=notifications&email_token=ADLPZUYZU5DWMHRZPXEXHXLP26E75A5CNFSM4HYJRYDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX3EASA#issuecomment-502677576">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ADLPZU6MEZJ6CZDVAQ667CDP26E75ANCNFSM4HYJRYDA">mute the thread</a>.<img src="https://github.com/notifications/beacon/ADLPZUYGPCNDE3SLCO2MSPLP26E75A5CNFSM4HYJRYDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX3EASA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/rpm-software-management/rpm/pull/751?email_source=notifications\u0026email_token=ADLPZUYZU5DWMHRZPXEXHXLP26E75A5CNFSM4HYJRYDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX3EASA#issuecomment-502677576",
"url": "https://github.com/rpm-software-management/rpm/pull/751?email_source=notifications\u0026email_token=ADLPZUYZU5DWMHRZPXEXHXLP26E75A5CNFSM4HYJRYDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX3EASA#issuecomment-502677576",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>