Hi Mark,<br>
<br>
> I don't think this should be part of add_minidebug (). It is something<br>
> that would need to happen even if we don't run add_minidebug (). Also<br>
> add_minidebug () runs after stripping/splitting the main ELF file into<br>
> a .debug file (which also gets a copy of all notes).<br>
> <br>
> I noticed older binutils objcopy don't seem to know about --merge-<br>
> notes. And produce large errors when trying to run.<br>
> <br>
> So I think this should be something like this, in do_file (), before<br>
> the binary is actually stripped.<br>
<br>
Thanks very much for the review and corrections.  As you might guess I am<br>
no rpm expert, so I wholeheartedly agree with the changes that you have <br>
proposed.<br>
<br>
Cheers<br>
  Nick<br>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you commented.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/751?email_source=notifications&email_token=ADLPZU2ATOW5C4NJDBCO7LTP26EIBA5CNFSM4HYJRYDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX3DQCA#issuecomment-502675464">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ADLPZU3ZZFHY7UO56VUIHQ3P26EIBANCNFSM4HYJRYDA">mute the thread</a>.<img src="https://github.com/notifications/beacon/ADLPZU3E66M4FY4YUGMSQZDP26EIBA5CNFSM4HYJRYDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX3DQCA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/rpm-software-management/rpm/pull/751?email_source=notifications\u0026email_token=ADLPZU2ATOW5C4NJDBCO7LTP26EIBA5CNFSM4HYJRYDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX3DQCA#issuecomment-502675464",
"url": "https://github.com/rpm-software-management/rpm/pull/751?email_source=notifications\u0026email_token=ADLPZU2ATOW5C4NJDBCO7LTP26EIBA5CNFSM4HYJRYDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX3DQCA#issuecomment-502675464",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>