<p><b>@pmatilai</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/rpm-software-management/rpm/pull/739#discussion_r294225714">build/parseChangelog.c</a>:</p>
<pre style='color:#555'>> @@ -44,7 +44,8 @@ static int dateToTimet(const char * datestr, time_t * secs, int * date_words)
     struct tm time, ntime;
     const char * const * idx;
     char *p, *pe, *q, *date, *tz;
-    char tz_name[10];               /* name of timezone (if extended format is used) */
+    char *tz_name = NULL;               /* TZ database name (if extended format is used) */
</pre>
<p>Similar to my other database complaints, the comment change seems quite questionable.<br>
It's not a name of the database as the comment now indicates, but the name of the timezone. No comment change is necessary, and in fact this never really needed that comment to begin with because the variable name says it all. And that we're wasting time discussing something like this is a fine example of superfluous comments being bad.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/739?email_source=notifications&email_token=ADLPZUYYNUOQEF64WQ74MODP25PB5A5CNFSM4HTUSY7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3WN5TY#pullrequestreview-250404559">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ADLPZU5ZR44YLS2YDDOX4ZLP25PB5ANCNFSM4HTUSY7A">mute the thread</a>.<img src="https://github.com/notifications/beacon/ADLPZU6DF7D27L7KISYK4Z3P25PB5A5CNFSM4HTUSY7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3WN5TY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/rpm-software-management/rpm/pull/739?email_source=notifications\u0026email_token=ADLPZUYYNUOQEF64WQ74MODP25PB5A5CNFSM4HTUSY7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3WN5TY#pullrequestreview-250404559",
"url": "https://github.com/rpm-software-management/rpm/pull/739?email_source=notifications\u0026email_token=ADLPZUYYNUOQEF64WQ74MODP25PB5A5CNFSM4HTUSY7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3WN5TY#pullrequestreview-250404559",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>