<p><b>@pmatilai</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/rpm-software-management/rpm/pull/746#discussion_r295737049">rpmio/macro.c</a>:</p>
<pre style='color:#555'>> +    SKIPBLANK(parts->g, c);
+
+    /* after %{? {macroo} must be ':' */
+    if (parts->g[0] == ':') {
+       parts->g++;
+       SKIPBLANK(parts->g,c);
+       parts->ge = parts->g;
+       while ((parts->ge[0] != 0) && (parts->ge[0] != ':')) {
+           parts->ge++;
+           if (parts->ge[0] == '{') {
+               if ((parts->ge = matchchar(parts->ge++, '{', '}')) == NULL)
+                   return NULL;
+           }
+       }
+    } else {
+       return NULL;
</pre>
<p>Arrange a single point of return to the function, goto exit or such.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/746?email_source=notifications&email_token=ADLPZU3ZHPULCSPDDTHH42TP3NJARA5CNFSM4HXHLHE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4EEJPA#pullrequestreview-252200124">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ADLPZU4M7MUYDW3TN23M4E3P3NJARANCNFSM4HXHLHEQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/ADLPZUZFDJPGMT2EGQ6IS6TP3NJARA5CNFSM4HXHLHE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4EEJPA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/rpm-software-management/rpm/pull/746?email_source=notifications\u0026email_token=ADLPZU3ZHPULCSPDDTHH42TP3NJARA5CNFSM4HXHLHE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4EEJPA#pullrequestreview-252200124",
"url": "https://github.com/rpm-software-management/rpm/pull/746?email_source=notifications\u0026email_token=ADLPZU3ZHPULCSPDDTHH42TP3NJARA5CNFSM4HXHLHE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4EEJPA#pullrequestreview-252200124",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>