<p><b>@pmatilai</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/rpm-software-management/rpm/pull/746#discussion_r295739132">rpmio/macro.c</a>:</p>
<pre style='color:#555'>> @@ -45,6 +45,12 @@ enum macroFlags_e {
     ME_USED    = (1 << 1),
 };
 
+enum checkConditionType {
+    CHK_NO             = 0,
+    CHK_BASIC          = (1 << 0),
+    CHK_TRIPLE         = (1 << 1),
+};
</pre>
<p>CHK_NO sounds like something that wants to pair with CHK_YES, but this is something entirely different.</p>
<p>I didn't really look whether it makes sense in the rest of the code, I'd expect the to be a CHK_EXISTS bit, and if its of the triple format, there'd be an extra bit set on that, instead of being entirely separate entities. But please rethink these names anyhow.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/746?email_source=notifications&email_token=ADLPZU34CZZ3HLWRYOLDYTTP3NJYDA5CNFSM4HXHLHE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4EE7HA#pullrequestreview-252202908">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ADLPZUY3WDSOO72757KILLLP3NJYDANCNFSM4HXHLHEQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/ADLPZU24PR7ESHC4CYKAI33P3NJYDA5CNFSM4HXHLHE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4EE7HA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/rpm-software-management/rpm/pull/746?email_source=notifications\u0026email_token=ADLPZU34CZZ3HLWRYOLDYTTP3NJYDA5CNFSM4HXHLHE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4EE7HA#pullrequestreview-252202908",
"url": "https://github.com/rpm-software-management/rpm/pull/746?email_source=notifications\u0026email_token=ADLPZU34CZZ3HLWRYOLDYTTP3NJYDA5CNFSM4HXHLHE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4EE7HA#pullrequestreview-252202908",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>