<p><b>@pmatilai</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/rpm-software-management/rpm/pull/746#discussion_r295739723">rpmio/macro.c</a>:</p>
<pre style='color:#555'>>      str++;
     }
     return str;
 }
 
+static void partsInit(macroPartition *parts)
+{
+    parts->f = parts->fe = NULL;
+    parts->g = parts->ge = NULL;
+    parts->h = parts->he = NULL;
+    parts->fn = parts->gn = parts->hn = 0;
+    return;
</pre>
<p>In general, never initialize more than one variable on a line, it only makes it harder to read. In a case like this, just memset() to zero.</p>
<p>The return at end of void function is redundant.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/746?email_source=notifications&email_token=ADLPZU5IVEBGC25IWNNC2T3P3NJ6PA5CNFSM4HXHLHE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4EFFKI#pullrequestreview-252203689">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ADLPZU5EDQ6VABUXBCGXFIDP3NJ6PANCNFSM4HXHLHEQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/ADLPZUZZCNMUSEUSOWTNH6TP3NJ6PA5CNFSM4HXHLHE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4EFFKI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/rpm-software-management/rpm/pull/746?email_source=notifications\u0026email_token=ADLPZU5IVEBGC25IWNNC2T3P3NJ6PA5CNFSM4HXHLHE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4EFFKI#pullrequestreview-252203689",
"url": "https://github.com/rpm-software-management/rpm/pull/746?email_source=notifications\u0026email_token=ADLPZU5IVEBGC25IWNNC2T3P3NJ6PA5CNFSM4HXHLHE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4EFFKI#pullrequestreview-252203689",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>