<p><b>@pmatilai</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/rpm-software-management/rpm/pull/739#discussion_r296645445">build/parseChangelog.c</a>:</p>
<pre style='color:#555'>> @@ -44,7 +44,8 @@ static int dateToTimet(const char * datestr, time_t * secs, int * date_words)
     struct tm time, ntime;
     const char * const * idx;
     char *p, *pe, *q, *date, *tz;
-    char tz_name[10];               /* name of timezone (if extended format is used) */
+    char *tz_name = NULL;               /* TZ database name (if extended format is used) */
</pre>
<p>Yes I can see it's used as a column name in that list, as a shorthard for "name <em>in</em> timezone database". But "foo database name" generally refers to the name of the database itself, not a value in it. If I were talking about "rpm database name", you wouldn't think of individual package names would you?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/739?email_source=notifications&email_token=ADLPZU27QQCMMVGUBMYBGBDP4CLNRA5CNFSM4HTUSY7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4MULYY#discussion_r296645445">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ADLPZUZSYJNPHPQ75ZMUK4LP4CLNRANCNFSM4HTUSY7A">mute the thread</a>.<img src="https://github.com/notifications/beacon/ADLPZU34E3EFDPKFDBCRJ3DP4CLNRA5CNFSM4HTUSY7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4MULYY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/rpm-software-management/rpm/pull/739?email_source=notifications\u0026email_token=ADLPZU27QQCMMVGUBMYBGBDP4CLNRA5CNFSM4HTUSY7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4MULYY#discussion_r296645445",
"url": "https://github.com/rpm-software-management/rpm/pull/739?email_source=notifications\u0026email_token=ADLPZU27QQCMMVGUBMYBGBDP4CLNRA5CNFSM4HTUSY7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4MULYY#discussion_r296645445",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>