<p><b>@pmatilai</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/rpm-software-management/rpm/pull/739#discussion_r296659642">build/parseChangelog.c</a>:</p>
<pre style='color:#555'>> @@ -178,13 +179,17 @@ static int dateToTimet(const char * datestr, time_t * secs, int * date_words)
 
     if (*secs == -1) goto exit;
 
+    if (tzname[1][0] == 0)
+       rpmlog(RPMLOG_WARNING, _("time zone in %%changelog not in tz database: %s\n"), datestr);
</pre>
<p>But it's not like <em>you're</em> consulting a timezone database here. What tzname contains is up to the libc implementation, <a href="https://pubs.opengroup.org/onlinepubs/9699919799/functions/tzset.html" rel="nofollow">https://pubs.opengroup.org/onlinepubs/9699919799/functions/tzset.html</a> or <a href="https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html#tag_08" rel="nofollow">https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html#tag_08</a> say nothing at all about any databases, much less that tzname[1] contains a value from the tz database.</p>
<p>In fact, tzname[1] is dst, of which the standard says:</p>
<blockquote>
<p>std and dst<br>
Indicate no less than three, nor more than {TZNAME_MAX}, bytes that are the designation for the standard (std) or the alternative (dst -such as Daylight Savings Time) timezone. Only std is required; if dst is missing, then the alternative time does not apply in this locale.</p>
</blockquote>
<p>This is far from my area of expertise but based on the above, I don't see how you can determine the validity from tzname[1].<br>
Further, tzname is a string so for an empty string you should be comparing for character '\0', not 0 the number. It might not make a difference to the computer but these things matter to the reader.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/739?email_source=notifications&email_token=ADLPZUZSEMV4UFCLXMPBLR3P4CP7PA5CNFSM4HTUSY7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4MYXNA#discussion_r296659642">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ADLPZUYBOXOKU3C4D2AUPU3P4CP7PANCNFSM4HTUSY7A">mute the thread</a>.<img src="https://github.com/notifications/beacon/ADLPZUYDXP5XUO4GYCI5ZD3P4CP7PA5CNFSM4HTUSY7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4MYXNA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/rpm-software-management/rpm/pull/739?email_source=notifications\u0026email_token=ADLPZUZSEMV4UFCLXMPBLR3P4CP7PA5CNFSM4HTUSY7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4MYXNA#discussion_r296659642",
"url": "https://github.com/rpm-software-management/rpm/pull/739?email_source=notifications\u0026email_token=ADLPZUZSEMV4UFCLXMPBLR3P4CP7PA5CNFSM4HTUSY7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4MYXNA#discussion_r296659642",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>