<p>Commit <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/rpm-software-management/rpm/commit/ee3126dd3d4ca609f254ac5d647c9ff3e413e9dd/hovercard" href="https://github.com/rpm-software-management/rpm/commit/ee3126dd3d4ca609f254ac5d647c9ff3e413e9dd"><tt>ee3126d</tt></a> added an innocent<br>
looking check to ban characters below < 0x20, but char is signed<br>
so it ends up banning the whole upper range too. Cast to unsigned<br>
and add a comment as a reminder. Thanks to Michael Schroeder for<br>
pointing this out!</p>
<p>Fixes <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/rpm-software-management/rpm/commit/ee3126dd3d4ca609f254ac5d647c9ff3e413e9dd/hovercard" href="https://github.com/rpm-software-management/rpm/commit/ee3126dd3d4ca609f254ac5d647c9ff3e413e9dd"><tt>ee3126d</tt></a></p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/rpm-software-management/rpm/pull/771'>https://github.com/rpm-software-management/rpm/pull/771</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Watch out for char signedness when checking for printable</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/rpm-software-management/rpm/pull/771/files#diff-0">build/files.c</a>
    (3)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/rpm-software-management/rpm/pull/771.patch'>https://github.com/rpm-software-management/rpm/pull/771.patch</a></li>
  <li><a href='https://github.com/rpm-software-management/rpm/pull/771.diff'>https://github.com/rpm-software-management/rpm/pull/771.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/771?email_source=notifications&email_token=ADLPZUZYXBTL2WTEETCJEQ3P4NZGVA5CNFSM4H3STAF2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G32E3CA">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ADLPZU56LKMQHI2TWTPFOHLP4NZGVANCNFSM4H3STAFQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/ADLPZU4IB4ACJY7RRXJKRY3P4NZGVA5CNFSM4H3STAF2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G32E3CA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/rpm-software-management/rpm/pull/771?email_source=notifications\u0026email_token=ADLPZUZYXBTL2WTEETCJEQ3P4NZGVA5CNFSM4H3STAF2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G32E3CA",
"url": "https://github.com/rpm-software-management/rpm/pull/771?email_source=notifications\u0026email_token=ADLPZUZYXBTL2WTEETCJEQ3P4NZGVA5CNFSM4H3STAF2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G32E3CA",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>