<p>Really bothers you, huh?</p>
<p>These are more on the cosmetic side, but nevertheless:</p>
<ul>
<li>Use existing string functions (strchr() and friends) instead of manual loops when possible</li>
<li>Use short variable names for temporary local strings, such as "s" which is used all over rpm codebase for such purposes.</li>
<li>You're adding code, not ripping something out. "Disable marker on multiline expression error messages" would be more like it (it also isn't limited to %{expr:...})</li>
<li>Multiline is typoed "mutiline" in the commit message</li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/828?email_source=notifications&email_token=ADLPZU5ZL7AI2SFRAYEXQR3QHYUQ5A5CNFSM4ITDTRX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5XSZXA#issuecomment-527379676">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ADLPZU477I4CD6WGUM6YWD3QHYUQ5ANCNFSM4ITDTRXQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/ADLPZU44ABDAYXFRI57ZHBLQHYUQ5A5CNFSM4ITDTRX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5XSZXA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/rpm-software-management/rpm/pull/828?email_source=notifications\u0026email_token=ADLPZU5ZL7AI2SFRAYEXQR3QHYUQ5A5CNFSM4ITDTRX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5XSZXA#issuecomment-527379676",
"url": "https://github.com/rpm-software-management/rpm/pull/828?email_source=notifications\u0026email_token=ADLPZU5ZL7AI2SFRAYEXQR3QHYUQ5A5CNFSM4ITDTRX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5XSZXA#issuecomment-527379676",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>