<p><b>@pmatilai</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/rpm-software-management/rpm/pull/830#discussion_r322224015">doc/manual/spec</a>:</p>
<pre style='color:#555'>> +%elifarch, %elifos or %else can be optionally used. Conditionals %endif and
+%else should not be followed by any text. Conditionals may be nested within
+other conditionals.
+
+Conditionals are not macros. It has an interesting consequence (similar as
+the fact that macros get expanded in comments). If a conditional is a part
+of a definition like
+\verbatim
+       %define macro_with_if \
+       %if 0  \
+       %global output XXX\
+       %endif
+\endverbatim
+the expansion (including %global) occurs before evaluating of the
+conditionals. Thus after the expansion of %macro_with_if macro %output
+is defined to XXX.
</pre>
<p>I don't think this last block belongs here, at least in this detail. Dark corners are often best left undocumented to allow changing if a saner behavior becomes feasible later. I'd condense that into something like:</p>
<p>%if-conditionals are not macros, and are unlikely to yield expected results if used in them.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/830?email_source=notifications&email_token=ADLPZU7KC7GTQVQMESOHFXDQIZBDVA5CNFSM4IT2P6UKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCECCAOI#pullrequestreview-285483065">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ADLPZUYIZLZNGL3G4ZSQJ63QIZBDVANCNFSM4IT2P6UA">mute the thread</a>.<img src="https://github.com/notifications/beacon/ADLPZU53BJSV3CUBILSO42LQIZBDVA5CNFSM4IT2P6UKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCECCAOI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/rpm-software-management/rpm/pull/830?email_source=notifications\u0026email_token=ADLPZU7KC7GTQVQMESOHFXDQIZBDVA5CNFSM4IT2P6UKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCECCAOI#pullrequestreview-285483065",
"url": "https://github.com/rpm-software-management/rpm/pull/830?email_source=notifications\u0026email_token=ADLPZU7KC7GTQVQMESOHFXDQIZBDVA5CNFSM4IT2P6UKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCECCAOI#pullrequestreview-285483065",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>