<p><b>@pmatilai</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/rpm-software-management/rpm/pull/828#discussion_r322198873">rpmio/expression.c</a>:</p>
<pre style='color:#555'>> @@ -110,6 +110,12 @@ typedef struct _parseState {
 static void exprErr(const struct _parseState *state, const char *msg,
                    const char *p)
 {
+    const char *s = state->str;
+
+    s = strchr(s,'\n');
+    if (s && (*(s+1) != '\0'))
+       p = NULL;
+
</pre>
<p>While "s" is perfectly acceptable variable name in a case like this, a more descriptive one would make the code that little bit more readable. Say, "nl" or even "newline", after which the whole thing reads almost as human language. <em>Almost</em> :)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/828?email_source=notifications&email_token=ADLPZU7FYR6XVLNH5JUM7LDQIYZ47A5CNFSM4ITDTRX2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCEB2ETY#pullrequestreview-285450831">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ADLPZUYXT3UYEH4734S7QGLQIYZ47ANCNFSM4ITDTRXQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/ADLPZU7X5Q444TUWF6LXKPDQIYZ47A5CNFSM4ITDTRX2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCEB2ETY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/rpm-software-management/rpm/pull/828?email_source=notifications\u0026email_token=ADLPZU7FYR6XVLNH5JUM7LDQIYZ47A5CNFSM4ITDTRX2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCEB2ETY#pullrequestreview-285450831",
"url": "https://github.com/rpm-software-management/rpm/pull/828?email_source=notifications\u0026email_token=ADLPZU7FYR6XVLNH5JUM7LDQIYZ47A5CNFSM4ITDTRX2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCEB2ETY#pullrequestreview-285450831",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>