<p>The %if lines in the specfile are expanded before the expressions<br>
get evaluated, so the re-expansion of strings is surprising.<br>
It's also not done for integers, which makes it inconsistent.</p>
<p>The original expression parser seems to have been written<br>
without taking the upfront expansion into account, thus the<br>
string expansion and the TOK_IDENTIFIER code.</p>
<p>As I can't imagine anybody using this feature lets just drop it.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/rpm-software-management/rpm/pull/845'>https://github.com/rpm-software-management/rpm/pull/845</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Stop expanding strings in the expression parser</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/rpm-software-management/rpm/pull/845/files#diff-0">rpmio/expression.c</a>
    (3)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/rpm-software-management/rpm/pull/845.patch'>https://github.com/rpm-software-management/rpm/pull/845.patch</a></li>
  <li><a href='https://github.com/rpm-software-management/rpm/pull/845.diff'>https://github.com/rpm-software-management/rpm/pull/845.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/845?email_source=notifications&email_token=ADLPZU2OJHUOZVNK4QOOVNLQKIBSFA5CNFSM4IX47NM2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HMDK7IQ">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ADLPZU2UNNNKVMDBALZLDN3QKIBSFANCNFSM4IX47NMQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/ADLPZUZH4RGHRCGZHHZU5TDQKIBSFA5CNFSM4IX47NM2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HMDK7IQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/rpm-software-management/rpm/pull/845?email_source=notifications\u0026email_token=ADLPZU2OJHUOZVNK4QOOVNLQKIBSFA5CNFSM4IX47NM2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HMDK7IQ",
"url": "https://github.com/rpm-software-management/rpm/pull/845?email_source=notifications\u0026email_token=ADLPZU2OJHUOZVNK4QOOVNLQKIBSFA5CNFSM4IX47NM2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HMDK7IQ",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>