<p><b>@nwnk</b> approved this pull request.</p>

<hr>

<p>In <a href="https://github.com/rpm-software-management/rpm/pull/860#discussion_r327689643">build/parsePrep.c</a>:</p>
<pre style='color:#555'>> @@ -329,8 +333,8 @@ static int doSetupMacro(rpmSpec spec, const char *line)
 
     /* if necessary, create and cd into the proper dir */
     if (createDir) {
-       buf = rpmExpand("%{__mkdir_p} ", spec->buildSubdir, "\n",
-                       "cd '", spec->buildSubdir, "'", NULL);
+       buf = rpmExpand("%{?_buildsubdir:%{__mkdir_p} '%{_buildsubdir}'\n}",
+                       "cd '%{_buildsubdir}'}", NULL);
</pre>
<p>The CI build caught this:</p>
<pre><code>/srv/rpm/rpm-4.15.90/_build/sub/tests/testing/tmp/rpm-tmp.5Xq9OQ: line 31: cd: test-1.0}: No such file or directory
</code></pre>
<p>You have an extra <code>}</code> in the <code>cd</code> command here.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/860?email_source=notifications&email_token=ADLPZU4DDCHSDAQT7EH2UYDQLKMXVA5CNFSM4I2A4OD2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFXYB6A#pullrequestreview-292520184">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ADLPZUZOG4HJR4W2YALJSY3QLKMXVANCNFSM4I2A4ODQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/ADLPZU4Z475HG3IUGF6MZETQLKMXVA5CNFSM4I2A4OD2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFXYB6A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/rpm-software-management/rpm/pull/860?email_source=notifications\u0026email_token=ADLPZU4DDCHSDAQT7EH2UYDQLKMXVA5CNFSM4I2A4OD2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFXYB6A#pullrequestreview-292520184",
"url": "https://github.com/rpm-software-management/rpm/pull/860?email_source=notifications\u0026email_token=ADLPZU4DDCHSDAQT7EH2UYDQLKMXVA5CNFSM4I2A4OD2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFXYB6A#pullrequestreview-292520184",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>