<p>Commit <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/rpm-software-management/rpm/commit/fa303d5ba6bef5b4a44b884c6dadadc27b594caa/hovercard" href="https://github.com/rpm-software-management/rpm/commit/fa303d5ba6bef5b4a44b884c6dadadc27b594caa"><tt>fa303d5</tt></a> moved buildhost and<br>
buildtime calculation out of the package generation to early spec<br>
initialization, but this broke reproducable builds: if buildtime is<br>
to be set from changelog, changelog needs to be parsed first.</p>
<p>So either we need to do it twice or we need to do it right, and<br>
besides avoiding duplication, conceptually these values are only<br>
meaningful during a build and not a parse, so this restores that part<br>
of the original code while keeping things thread-safe.</p>
<p><span class="issue-keyword tooltipped tooltipped-se" aria-label="This pull request closes issue #932.">Fixes</span>: <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="520024641" data-permission-text="Issue title is private" data-url="https://github.com/rpm-software-management/rpm/issues/932" data-hovercard-type="issue" data-hovercard-url="/rpm-software-management/rpm/issues/932/hovercard" href="https://github.com/rpm-software-management/rpm/issues/932">#932</a></p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/rpm-software-management/rpm/pull/935'>https://github.com/rpm-software-management/rpm/pull/935</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Only calculate buildhost and buildtime during an actual build</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/rpm-software-management/rpm/pull/935/files#diff-0">build/build.c</a>
    (49)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/rpm-software-management/rpm/pull/935/files#diff-1">build/spec.c</a>
    (50)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/rpm-software-management/rpm/pull/935.patch'>https://github.com/rpm-software-management/rpm/pull/935.patch</a></li>
  <li><a href='https://github.com/rpm-software-management/rpm/pull/935.diff'>https://github.com/rpm-software-management/rpm/pull/935.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/935?email_source=notifications&email_token=ADLPZU5ONDHP5CZICBE5PKDQTEYKBA5CNFSM4JLTSK5KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HYL4FYQ">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ADLPZU2WC6PCI23NUQIAVXLQTEYKBANCNFSM4JLTSK5A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ADLPZU5SWTQZFEZV3OSRT6TQTEYKBA5CNFSM4JLTSK5KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HYL4FYQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/rpm-software-management/rpm/pull/935?email_source=notifications\u0026email_token=ADLPZU5ONDHP5CZICBE5PKDQTEYKBA5CNFSM4JLTSK5KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HYL4FYQ",
"url": "https://github.com/rpm-software-management/rpm/pull/935?email_source=notifications\u0026email_token=ADLPZU5ONDHP5CZICBE5PKDQTEYKBA5CNFSM4JLTSK5KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HYL4FYQ",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>