<p><b>@mlschroe</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/rpm-software-management/rpm/pull/1038#discussion_r374009623">tools/elfdeps.c</a>:</p>
<pre style='color:#555'>> +    break;
+    case EM_MIPS:
+       elf_machine = "mips";
+       break;
+    case EM_PPC:
+    case EM_PPC64:
+       elf_machine = "ppc";
+       break;
+    case EM_S390:
+       elf_machine = "s390";
+       break;
+    case EM_ARM:
+       if ((ehdr->e_flags | EF_ARM_ABI_FLOAT_HARD) == EF_ARM_ABI_FLOAT_HARD)
+               elf_machine = "armhfp";
+       if ((ehdr->e_flags | EF_ARM_ABI_FLOAT_SOFT) == EF_ARM_ABI_FLOAT_SOFT)
+               elf_machine = "armsfp";
</pre>
<p>Those two if statements look fishy. I expected something like <code>(ehdr->e_flags & ~EF_ARM_ABI_FLOAT_HARD) == EF_ARM_ABI_FLOAT_HARD</code></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/1038?email_source=notifications&email_token=ADLPZU4BZ2PLLB23Y55DDCDRA7S2HA5CNFSM4KOXDTT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCT6R7EY#pullrequestreview-352133011">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ADLPZU6OSM6PQR5DLBB5LZTRA7S2HANCNFSM4KOXDTTQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ADLPZU454KFHWI24BJNYBC3RA7S2HA5CNFSM4KOXDTT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCT6R7EY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/rpm-software-management/rpm/pull/1038?email_source=notifications\u0026email_token=ADLPZU4BZ2PLLB23Y55DDCDRA7S2HA5CNFSM4KOXDTT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCT6R7EY#pullrequestreview-352133011",
"url": "https://github.com/rpm-software-management/rpm/pull/1038?email_source=notifications\u0026email_token=ADLPZU4BZ2PLLB23Y55DDCDRA7S2HA5CNFSM4KOXDTT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCT6R7EY#pullrequestreview-352133011",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>