<p><b>@pmatilai</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/rpm-software-management/rpm/pull/1043#discussion_r374546403">build/files.c</a>:</p>
<pre style='color:#555'>> @@ -2244,6 +2245,12 @@ int readManifest(rpmSpec spec, const char *path, const char *descr, int flags,
            continue;
        if (specExpand(spec, lineno, buf, &expanded))
            goto exit;
+       if (flags & STRIP_TRAILINGSPACE) {
+           char *end = expanded + strlen(expanded) - 1;
+           while (end >= expanded && isspace((unsigned char)*end))
</pre>
<p>Use risspace() instead, it'll also save you from having to include ctype.h</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/1043?email_source=notifications&email_token=ADLPZU2QSBDEAL7AJ6AWEH3RBEVRXA5CNFSM4KPHM3AKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCUDYCGI#pullrequestreview-352813337">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ADLPZUZLBRUIEZKS7V7NKKLRBEVRXANCNFSM4KPHM3AA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ADLPZUZB4J3N7PCEHBGKTLTRBEVRXA5CNFSM4KPHM3AKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCUDYCGI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/rpm-software-management/rpm/pull/1043?email_source=notifications\u0026email_token=ADLPZU2QSBDEAL7AJ6AWEH3RBEVRXA5CNFSM4KPHM3AKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCUDYCGI#pullrequestreview-352813337",
"url": "https://github.com/rpm-software-management/rpm/pull/1043?email_source=notifications\u0026email_token=ADLPZU2QSBDEAL7AJ6AWEH3RBEVRXA5CNFSM4KPHM3AKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCUDYCGI#pullrequestreview-352813337",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>