<p><b>@pmatilai</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/rpm-software-management/rpm/pull/1043#discussion_r374710238">build/parseList.c</a>:</p>
<pre style='color:#555'>> @@ -8,13 +8,99 @@
 #include "build/rpmbuild_internal.h"
 #include "debug.h"
 
+static int addLinesFromFile(rpmSpec spec, const char * const fn, rpmTagVal tag)
+{
+    int nlines = 0;
+    int flags = STRIP_COMMENTS | STRIP_TRAILINGSPACE;
+    ARGV_t argv = NULL;
+
+    int terminate = rpmExpandNumeric(tag == RPMTAG_SOURCE
+                                    ? "%{?_empty_sourcelist_terminate_build}"
+                                    : "%{?_empyy_patchlist_terminate_build}");
</pre>
<p>Fair enough I guess. But if we consider it valid then let it always be valid. We have way, way too many of these fiddly configurables as it is.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/1043?email_source=notifications&email_token=ADLPZUZRXW4TEKMC3TDSKJTRBF5HBA5CNFSM4KPHM3AKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCUFMRJI#discussion_r374710238">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ADLPZU5CUNBIFVCEJMHLCCDRBF5HBANCNFSM4KPHM3AA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ADLPZUY5ALDBAFSAU25MFTDRBF5HBA5CNFSM4KPHM3AKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCUFMRJI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/rpm-software-management/rpm/pull/1043?email_source=notifications\u0026email_token=ADLPZUZRXW4TEKMC3TDSKJTRBF5HBA5CNFSM4KPHM3AKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCUFMRJI#discussion_r374710238",
"url": "https://github.com/rpm-software-management/rpm/pull/1043?email_source=notifications\u0026email_token=ADLPZUZRXW4TEKMC3TDSKJTRBF5HBA5CNFSM4KPHM3AKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCUFMRJI#discussion_r374710238",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>