<p><b>@pmatilai</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/rpm-software-management/rpm/pull/1043#discussion_r379289807">build/parseList.c</a>:</p>
<pre style='color:#555'>> +           spec->lineNum, name, poptStrerror(rc));
+       goto exit;
+    }
+
+    optCon = poptGetContext(NULL, argc, argv, optionsTable, 0);
+    while ((arg = poptGetNextOpt(optCon)) > 0) {
+
+       char * filename = poptGetOptArg(optCon);
+       if (!filename) {
+           rpmlog(RPMLOG_ERR,
+                  _("line %d: \"%%%s -f\" requires an argument.\n"),
+                  spec->lineNum, name);
+           goto exit;
+       }
+
+       addSource(spec, 0, filename, RPMTAG_SOURCE);
</pre>
<p>Mm. This is out of line with our -f usage elsewhere: we don't ask questions about the file origin external sources are pulled in, whether that's %include'd or pulled via -f from in scriptlet, files manifest or otherwise. Much less make them our own.</p>
<p>I can see a use-case for at least %patchlist -f (not so sure about %sourcelist -f), but these external entities are problematic in general as they break the standalone expectations that people have on specs. %include is notoriously nasty, so the question is do we really want more of that?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/1043?email_source=notifications&email_token=ADLPZUZ6DB6XWRQDI62LKK3RCZENDA5CNFSM4KPHM3AKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCVREBVY#pullrequestreview-358760663">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ADLPZU5NM6O2TTFSDNQXV5TRCZENDANCNFSM4KPHM3AA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ADLPZU6DXPJDQMRWH6DZMLLRCZENDA5CNFSM4KPHM3AKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCVREBVY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/rpm-software-management/rpm/pull/1043?email_source=notifications\u0026email_token=ADLPZUZ6DB6XWRQDI62LKK3RCZENDA5CNFSM4KPHM3AKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCVREBVY#pullrequestreview-358760663",
"url": "https://github.com/rpm-software-management/rpm/pull/1043?email_source=notifications\u0026email_token=ADLPZUZ6DB6XWRQDI62LKK3RCZENDA5CNFSM4KPHM3AKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCVREBVY#pullrequestreview-358760663",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>