<p></p>
<blockquote>
<p>Oh, I've been alerted by <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/torsava/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/torsava">@torsava</a> that my suggestions have been addressed. Nice, thanks! The code looks good to me. If the external tests still pass, let's ship it?</p>
<p>We can probably test this in Fedora before merging if we want more testing (but this is not necessary).</p>
<p>Thank you <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/s-t-e-v-e-n-k/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/s-t-e-v-e-n-k">@s-t-e-v-e-n-k</a>!</p>
</blockquote>
<p>I'd prefer to merge it here, we've delayed the PR long enough :) We'll test it in Fedora in any case, and we can address possible issues later.</p>
<p>Thank you <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/s-t-e-v-e-n-k/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/s-t-e-v-e-n-k">@s-t-e-v-e-n-k</a> for having patience with us :)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/1317#issuecomment-724772529">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ADLPZU5IVLLRXZWCUY7X3ODSPFLHBANCNFSM4PFO3KLQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ADLPZUYSFHXQA3HJ73A4YDTSPFLHBA5CNFSM4PFO3KL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFMZSNMI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/rpm-software-management/rpm/pull/1317#issuecomment-724772529",
"url": "https://github.com/rpm-software-management/rpm/pull/1317#issuecomment-724772529",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>