<p>The intent of %exclude was always to merely support sub-packaging with<br>
wildcards in %files sections, not to permit leaving junk in the buildroot.<br>
Enforce this by checking against the actually packaged contents rather<br>
than everything we encountered during collection. This also gets rid<br>
of the ugly static check_fileList buffer - besides being ugly, such things<br>
are bad for parallelism.</p>
<p>This has been widely abused so the change is likely to break quite a few<br>
packages in the wild. As a side-effect this also cures a long-standing bug<br>
where unpackaged excluded files leak their debuginfo into packaged contents,<br>
as such a package will now fail to build at (RhBug:878863)</p>
<p><span class="issue-keyword tooltipped tooltipped-se" aria-label="This pull request closes issue #994.">Fixes</span>: <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="544561311" data-permission-text="Title is private" data-url="https://github.com/rpm-software-management/rpm/issues/994" data-hovercard-type="issue" data-hovercard-url="/rpm-software-management/rpm/issues/994/hovercard" href="https://github.com/rpm-software-management/rpm/issues/994">#994</a></p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/rpm-software-management/rpm/pull/1442'>https://github.com/rpm-software-management/rpm/pull/1442</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Require everything in buildroot to be packaged (#994)</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/rpm-software-management/rpm/pull/1442/files#diff-0fe6f6392e998226cdd81eedfa295f6da7cecfb4a4f768d52d88dad4d5622beb">build/files.c</a>
    (36)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/rpm-software-management/rpm/pull/1442/files#diff-9a03eeabc0b97b2cb9accc7088275b06a6d93a0f4fef7b5c732cdb8bb7564838">tests/data/SPECS/hlinktest.spec</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/rpm-software-management/rpm/pull/1442/files#diff-62808dc869ca5bfc1294ae4a6b18edab2d0a974870eb8b236c1c6a1bcb27df68">tests/data/SPECS/test-subpackages-exclude.spec</a>
    (11)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/rpm-software-management/rpm/pull/1442/files#diff-a6fbb82a7ba134e25366e845ff066015eebdcdb13687ec7fb5578b51f0992ba1">tests/rpmbuild.at</a>
    (37)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/rpm-software-management/rpm/pull/1442.patch'>https://github.com/rpm-software-management/rpm/pull/1442.patch</a></li>
  <li><a href='https://github.com/rpm-software-management/rpm/pull/1442.diff'>https://github.com/rpm-software-management/rpm/pull/1442.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/1442">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ADLPZU2F7KBEJ45YO73FUNTSQN74BANCNFSM4TZUOOVA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ADLPZU6Z3HIYHMGW7PH4TCDSQN74BA5CNFSM4TZUOOVKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4LDORT2Q.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/rpm-software-management/rpm/pull/1442",
"url": "https://github.com/rpm-software-management/rpm/pull/1442",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>