<p></p>
<blockquote>
<p>I was about to ask whether you're expecting a review on this (generally PR's with failing tests will not be looked at), but then I noticed this is a "draft", I didn't even know GH has such a (handy looking) feature so thanks for the tip</p>
</blockquote>
<p>Yeah, it's nice. It's just the <code>[WIP]</code> prefix, "standardized", plus it prevents one from accidentally merging it (which probably never happens anyway, but it improves peace of mind) :)</p>
<blockquote>
<pre><code>* Do split the log message improvements to a separate PR from the rpmlog infrastructure work
</code></pre>
</blockquote>
<p>Good point. I'll split it later.</p>
<blockquote>
<pre><code>* For the task of finding the last newline, the standard C library has (for once!) strrchr() so you don't need to do that manually
</code></pre>
</blockquote>
<p>Oh, of course. What I wanted was the <em>index</em> of the last non-newline char, which is why I didn't go for <code>strchr()</code> as it returns a pointer... except that it didn't occur to me that you can get the index with simple pointer arithmetic... sigh. Thanks for noticing :)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/1429#issuecomment-732110842">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ADLPZU25WX7SQSRPNWAXC53SRJDOLANCNFSM4TPYLAQA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ADLPZU5N5OMCUXM5H7RGJWDSRJDOLA5CNFSM4TPYLAQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFORR76Q.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/rpm-software-management/rpm/pull/1429#issuecomment-732110842",
"url": "https://github.com/rpm-software-management/rpm/pull/1429#issuecomment-732110842",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>