<p></p>
<p>I did some testing in dnfdaemon and the patch is working for us. Just (as Panu mentioned) for consistency I'd like to change CompleteTransaction signal name to EndTransaction - the signal is emitted regardless the transaction was successful and "Complete" in the name suggests the success.<br>
I was also thinking whether the result of the transaction should be part of the signal but having rpmdb cookie is perfectly fine with us to decide whether there actually was any change.<br>
I suppose the plugin will be released as a separate sub-package so that the dnfdaemon  could depend on it.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/1255#issuecomment-733608943">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ADLPZUY6VWQRVL2WCWKDRHTSRTJ6TANCNFSM4NSPITIA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ADLPZU63LD7OTGJUVM6FDULSRTJ6TA5CNFSM4NSPITIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFO47X3Y.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/rpm-software-management/rpm/pull/1255#issuecomment-733608943",
"url": "https://github.com/rpm-software-management/rpm/pull/1255#issuecomment-733608943",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>