[Rpm-ecosystem] Best practices for replacing directories

[Jason L Tibbitts III]

In the Fedora packaging guidelines we have the following section on
replacing a directory with a non-directory, and replacing a symlink with
a directory:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Directory_Replacement/#_scriptlet_to_replace_a_directory

Recently we received a ticket asking us to revise this slightly:
https://pagure.io/packaging-committee/issue/859

The suggested revision to the lua code is minor and I suppose makes
sense, but I'm reluctant to touch anything at all here because the issue
is subtle.  Furthermore, RPM could potentially change how it deals with
these cases; for all I know it may even do "the right thing" internally
now.

Does the Fedora guideline match the current guidance from RPM upstream
as to how to deal with these situations?

 - J<