[Rpm-maint] [Patch 06/19] Revert to using perl.req and .prov

Paul Nasrat pnasrat at redhat.com
Fri Feb 9 13:57:33 UTC 2007


On Fri, 2007-02-09 at 08:43 -0500, James Olin Oden wrote:
> <snip>
> > As I said this is meant as a merge of mostly functional changes, and I
> > want to look at the underlying methodologies individually, as such major
> > reworking getOutputFrom was beyond the scope of this patchset. My
> > prefered approach to fixing perl.req/prov was mentioned in an earlier
> > mail and I'd like to revisit how file class requires and provides are
> > handled generically.
> >
> Hey Paul,
> 
> I'd be very interested in getting this script to work.  With the
> packages sets I've used the "Turner" script after some mods I made
> seemed to produce the correct results and was way more readable (read
> maintable) than the old scripts.

I think the main thing we might need to do is fix the script to work
with both files in @ARGV or files coming from <stdin>. I don't imagine
that's too much work.  I just tried the same build with adding a quick
hack. The previous failing build now succeeds. I'm pretty sure this
isn't the nicest way to do the processing but perhaps you can use that
as a guide to how to fix properly:

Executing(%clean): /bin/sh -e /var/tmp/rpm-tmp.49511
+ umask 022
+ cd /home/pauln/work/devel/perl-Archive-Tar
+ cd Archive-Tar-1.30
+ rm -rf /var/tmp/perl-Archive-Tar-1.30-1.fc7-root-pauln
+ exit 0

rpm -qpR perl-Archive-Tar-1.30-1.fc7.noarch.rpm 
/usr/bin/perl  
perl >= 0:5.005.03
perl(:MODULE_COMPAT_5.8.8)  
perl(Archive::Tar)  
perl(Archive::Tar::Constant)  
perl(Archive::Tar::File)  
perl(Carp)  
perl(Compress::Zlib)  
perl(Config)  
perl(Cwd)  
perl(File::Basename)  
perl(File::Find)  
perl(File::Path)  
perl(File::Spec)  
perl(File::Spec::Unix)  
perl(Getopt::Std)  
perl(IO::File)  
perl(IO::Zlib)  
perl(constant)  
perl(strict)  
perl(vars)  
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1

rpm -qp --provides perl-Archive-Tar-1.30-1.fc7.noarch.rpm 
perl(Archive::Tar)  
perl(Archive::Tar::Constant)  
perl(Archive::Tar::File)  
perl-Archive-Tar = 1.30-1.fc7

Paul
--- /usr/lib/rpm/perldeps.pl	2006-11-10 16:54:44.000000000 +0000
+++ /home/pauln/bin/perldeps.pl	2007-02-09 13:52:40.000000000 +0000
@@ -18,6 +18,11 @@
   $deps->process_file($file);
 }
 
+while(<>) {
+  my $file = $_;
+  $deps->process_file($file);
+}
+
 if ($show_requires) {
   for my $req ($deps->requires) {
     my $verbage = "";





More information about the Rpm-maint mailing list