[Rpm-maint] [PATCH] rpmbuild: clean up buildroot handling, set a default buildroot

Michael Schroeder mls at suse.de
Fri Feb 16 11:11:16 UTC 2007


On Thu, Feb 15, 2007 at 02:57:37PM -0500, Bill Nottingham wrote:
> Tom 'spot' Callaway (tcallawa at redhat.com) said: 
> > But that's patently dangerous.
> > 
> > When do we EVER want the default buildroot to be none (which equates
> > to /) ? There's never a good case in my mind for that.
> 
> Michael? You said you didn't want to break compatibility?

Right. In my opinion rpm should have a way to specify a
system policy (this would be a %buildroot definition in the
macros file), but those policies should not be hardcoded
in the source. That's why there is a macros file at all, isn't it?

Tom says he known of no good case, but that's beside the point,
it makes no sense to break compatibility just because you
don't like something.

IMHO it should be:

- no buildroot coded into rpm
- rpm ships with %buildroot set to something sensible in the
  default macros file

As of the specfile buildroot taking precedence over the system
buildroot, I'm a bit torn here. On the one hand, it is logical
and intuitive if it does, on the other hand the system's definition
will be better in most cases.

Cheers,
  Michael.

-- 
Michael Schroeder                                   mls at suse.de
main(_){while(_=~getchar())putchar(~_-1/(~(_|32)/13*2-11)*13);}



More information about the Rpm-maint mailing list