[Rpm-maint] [Suse patch] Revert default %defattr(-,root,root)
Panu Matilainen
pmatilai at redhat.com
Tue May 22 08:38:23 UTC 2007
In principle I do agree that a macro would be better for inserting
whatever default defattr vendors want instead of hardcoding it to root
but...
The default %defattr(-,root,root) has been in rpm since 4.4 and people
might be relying on it, just disabling the behavior is not acceptable for
maintenance release I think. Willing to reconsider if a patch
seamlessly implementing the defattr in a macro magically appears :)
- Panu -
---
Revert upstream patch that always uses %defattr(-,root,root).
Upstream should probably use a macro instead.
--- ./build/files.c.orig 2005-12-14 19:22:43.000000000 +0000
+++ ./build/files.c 2006-02-17 13:57:25.000000000 +0000
@@ -2000,7 +2012,9 @@ static int processPackageFiles(Spec spec
nullAttrRec(&fl.cur_ar);
nullAttrRec(&fl.def_ar);
+#if 0
dupAttrRec(&root_ar, &fl.def_ar); /* XXX assume %defattr(-,root,root) */
+#endif
fl.defVerifyFlags = RPMVERIFY_ALL;
fl.nLangs = 0;
More information about the Rpm-maint
mailing list