[Rpm-maint] [Patch] rpmtsAddInstallElement() failure checking in python

[seth vidal]

On Tue, 2007-05-22 at 11:26 +0300, Panu Matilainen wrote:
> Attached patch (mentioned in the payload format patch commentary) makes 
> the python bindings throw an exception when ts.addInstall() fails, whereas 
> previously it would just silently fail.

What things cause the failure?

> pyrpmError might be a better exception to raise, the TypeError is there 
> because in theory, any callers should already be catching TypeError as 
> there are a couple of ways it could raise a TypeError exception as is. But 
> IIRC at least yum doesn't because the other causes are somewhat obscure. 
> OTOH if rpmtsAddInstallElement() fails the install will fail in one way or 
> the other anyway, it's just a matter of failing in a different way.
> 
> Another alternative could be returning the result from 
> rpmtsAddInstallElement() directly, so that it'd be possible to check but 
> unmodified clients would behave the same as they are now - silently 
> ignoring and failing late.
> 
> Raising an exception seems like the right thing to do, but do people think 
> it's too disruptive a change for a maintenance release of rpm?

I don't see any harm in adding in the exception, I just have a feeling
it won't matter a hill of beans. :)

-sv