[Rpm-maint] Re: [Suse patch] Don't block signals in ro-mode

Michael Schroeder mls at suse.de
Fri May 25 12:37:39 UTC 2007


On Fri, May 25, 2007 at 01:47:46PM +0300, Panu Matilainen wrote:
> On Fri, 25 May 2007, Panu Matilainen wrote:
> >
> >With this patch, stale ro-locks are left behind when running as root and 
> >interrupted (eg rpm -qa), not good.

Oh, so that's why the signals are also blocked in ro mode. I always 
wondered if that was just a mistake.

So the signal handling patch should check if the db is private
or not.

The big question is, of course, if you want to support both
locking strategies or not.

> ...unless private locking is used, which is what Suse does (patch below). 
> Isn't this already configurable through %__dbi_foo macros?

Yes, this patch is probably not really needed. I was just too
lazy to check the code. ;-)

Cheers,
  Michael.

-- 
Michael Schroeder                                   mls at suse.de
SUSE LINUX Products GmbH, GF Markus Rex, HRB 16746 AG Nuernberg
main(_){while(_=~getchar())putchar(~_-1/(~(_|32)/13*2-11)*13);}



More information about the Rpm-maint mailing list