[Rpm-maint] [Suse patch] Checking for identical packages on install/upgrade

[Paul Nasrat]

On Tue, 2007-05-29 at 10:29 +0300, Panu Matilainen wrote:
> For full background see 
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=104066. And yes I do 
> think it's a bug that we should fix.
> 

> I'd rather just use rpmdsCompare() for the check rather than add yet 
> another codepath for NEVRA comparison within rpm like the included patch 
> does. Optionally we could check for the HDRID as well (identical packages 
> are never wanted in ts) but dunno if it's worth the couple of more lines 
> because most of the time we'd be doing the version comparison anyway.
> 

Reducing the number of comparison functions is certainly desirable
rather than adding them. I'd agree with you that using dsCompare sounds
like it'd what Michael was trying to acheive here.

I also think guarding against identical packages is probably worth it in
the long run.

Paul