[Rpm-maint] [PATCH] forbid #%define

[Manfred Hollstein]

On Thu, 05 Jun 2008, 16:36:39 +0200, Pixel wrote:
> without this patch, "#%define foo bar" is surprisingly equivalent to "%define foo bar"
> with this patch, "#%define foo bar" is a fatal error.

Hmm, to me this appears like papering over a real problem...

> if you think it's worth it, i can frontport it to git master (this one
> is for rpm-4.4.x)
> 
> we could also disable macro expansion in "#%define ....", 
> or in all "#..." (hum, bigger pbs here)?

... as this appears much more "normal" from a user perspective. When I'm
writing shell scripts and want to test/debug some areas, I'll just
comment them by prefixing the stuff with the usual '#' when I'm done.
Dunno if it's documented anywhere in the RPM documentation that "#...'
is deprecated/should not be used, but I'd prefer that we fix those
issues, where a prefixing '#' still results in getting the remainder of
that line being evaluated...

Cheers.

l8er
manfred