[Rpm-maint] [PATCH] forbid #%define

[Peter Bowen]

On Fri, 2008-06-06 at 17:33 +0300, Panu Matilainen wrote:
> On Fri, 6 Jun 2008, Pixel wrote:
> > Panu Matilainen <pmatilai at redhat.com> writes:
> >
> >> A very straightforward and simple rule would be "if the first
> >> character of the text to process starts is "#", braces are required to perform
> >> macro expansion"
> >
> > i'd rather not introduce such a difference between %foo and %{foo}
> > just for the sake of comments. Too surprising IMO.
> 
> I'm not saying it's necessarily "the right thing", but is it really more 
> surprising than #-commenting not honored in specs which started this 
> thread? :) Remember, the only thing the patch affects is macros on 
> commented lines and nothing else. 

There are lots of other instances of # not being honored in specs.  For
example, lots of spec comments end up in scriptlets because someone did

%pre
..

# Remember to fix the call to fuzz in postun once we fix the main binary
%postun
..

%files

The comment ends up as the last line of the %pre scriptlet.

Thanks.
Peter