[Rpm-maint] [PATCH] Move header reading part from rpminstall to tryReadHeader function.

[Panu Matilainen]

On Sat, 14 Mar 2009, Rakesh Pandit wrote:

> 2009/3/13 Panu Matilainen wrote:
>> On Wed, 11 Mar 2009, Rakesh Pandit wrote:
> [..]
>> Seems sane to me, just a minor nit:
>> [pmatilai at localhost rpm]$ make -j4 > /dev/null
>> rpminstall.c: In function ‘tryReadHeader’:
>> rpminstall.c:328: warning: unused variable ‘rc’
>>
>> Somewhat related thing (not introduced by this): while cleaning things up
>> and moving things about, might as well get rid of those silly unused "xx"
>> variables. Either the return code should be checked for and acted upon, or
>> in cases like this where you just dont care if Fclose() succeeds or not,
>> just ignore it.
>>
>>        - Panu -
>
> Thanks.
>
> Updated: http://rakesh.fedorapeople.org/rpm/0001--Move-header-reading-part-from-rpminstall-to-tryRea.patch

Apologies for the delay, applied now. Just a couple of remarks:
- Please avoid mixing unrelated things in patches no matter how small.
   For an actual code change it's not acceptable, but in this case I let
   the psm include removal slip through as it doesn't affect code.
- Try to use a consistent commit log format with the "rpm style". Not
   end of the world by any means but the changelog looks better if the
   entries are in the same style, basically:

 	One-liner summary of the commit
 	- more explanation why the change was done
 	- ever the more important if subtleties are involved

- A further cleanup suggestion: with this patch it becomes very obvious 
that eiu->fd is only used locally in the tryReadFoo() functions and can 
(and should) be eliminated from struct rpmEIU.

Thanks!

 	- Panu -