[Rpm-maint] [PATCH] Move header reading part from rpminstall to tryReadHeader function.

[Rakesh Pandit]

2009/4/23 Panu Matilainen wrote:
> On Sat, 14 Mar 2009, Rakesh Pandit wrote:
[..]
> Apologies for the delay, applied now. Just a couple of remarks:

No problem.

> - Please avoid mixing unrelated things in patches no matter how small.
>  For an actual code change it's not acceptable, but in this case I let
>  the psm include removal slip through as it doesn't affect code.

Yep, very important ... will keep this in mind .. for future.

> - Try to use a consistent commit log format with the "rpm style". Not
>  end of the world by any means but the changelog looks better if the
>  entries are in the same style, basically:
>
>        One-liner summary of the commit
>        - more explanation why the change was done
>        - ever the more important if subtleties are involved
>

Yeah .. I missed here. *noted down* for future.

> - A further cleanup suggestion: with this patch it becomes very obvious that
> eiu->fd is only used locally in the tryReadFoo() functions and can (and
> should) be eliminated from struct rpmEIU.
>

Yes, very much .. *noted*, thanks for suggestions!

--
Regards,
Rakesh Pandit