[Rpm-maint] [PATCH] Removing extra useless 'break' statement lines.

[Panu Matilainen]

On Fri, 24 Apr 2009, Rakesh Pandit wrote:

> yeah yeah -- I am at rpmgi now, seriously :)
>
> http://rakesh.fedorapeople.org/rpm/0003-Removing-extra-useless-break-statement-lines.patch
> ---
> lib/rpmgi.c |    7 ++-----
> 1 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/lib/rpmgi.c b/lib/rpmgi.c
> index 4f9692e..9719cdd 100644
> --- a/lib/rpmgi.c
> +++ b/lib/rpmgi.c
> @@ -223,10 +223,6 @@ rpmlog(RPMLOG_DEBUG, "FTS_%s\t%*s %s%s\n",
> ftsInfoStr(fts->fts_info),
> 	((fts->fts_info == FTS_D || fts->fts_info == FTS_DP) ? "/" : ""));
>
>     switch (fts->fts_info) {
> -    case FTS_D:		/* preorder directory */
> -	break;
> -    case FTS_DP:	/* postorder directory */
> -	break;
>     case FTS_F:		/* regular file */
> 	/* Ignore all but *.rpm files. */
> 	s = fts->fts_name + fts->fts_namelen + 1 - sizeof(".rpm");
> @@ -234,10 +230,11 @@ rpmlog(RPMLOG_DEBUG, "FTS_%s\t%*s %s%s\n",
> ftsInfoStr(fts->fts_info),
> 	    break;
> 	rpmrc = RPMRC_OK;
> 	break;
> +    case FTS_D:		/* preorder directory */
> +    case FTS_DP:	/* postorder directory */
>     case FTS_NS:	/* stat(2) failed */
>     case FTS_DNR:	/* unreadable directory */
>     case FTS_ERR:	/* error; errno is set */
> -	break;
>     case FTS_DC:	/* directory that causes cycles */
>     case FTS_DEFAULT:	/* none of the above */
>     case FTS_DOT:	/* dot or dot-dot */

Might as well kick out all these unhandled FTS_FOO cases and let them fall 
on the default case, "documenting" all the possibilities serves little 
purpose here I think.

 	- Panu -