[Rpm-maint] [PATCH] Move vsflags calculation from rpmInstall and rpmErase to rpmSetVSFlags

[Rakesh Pandit]

2009/2/10 Panu Matilainen wrote:
> On Mon, 19 Jan 2009, Rakesh Pandit wrote:
[..]
>> +{
>> +    rpmVSFlags vsflags;
>> +
>> +    if (ia->cliInterfaceFlags & (RPMCLI_UPGRADE | RPMCLI_ERASE))
>> +       vsflags = rpmExpandNumeric("%{?_vsflags_erase}");
>> +    else
>> +       vsflags = rpmExpandNumeric("%{?_vsflags_install}");
>
> Nothing wrong here, just a side note: having separate _vsflags_erase and
> _vsflags_install is pretty much meaningless, _vsflags_erase gets used for
> practically everything. What might be somewhat useful is having different
> verify flags used for rpmdb and package files (you probably "trust" the
> rpmdb contents so might want to skip signature checks on rpmdb headers but
> for external packages you always want full checks) in the same operation,
> but the vsflags can't express that as it is.
>

Yeah, right. Will do an investigate on this some time.

-- 
Regards,
Rakesh Pandit