[Rpm-maint] [PATCH] Expand $HOME by hand in the default for %_topdir

David Malcolm dmalcolm at redhat.com
Tue Jan 13 16:48:37 UTC 2009


On Tue, 2009-01-13 at 09:49 -0500, Adam Jackson wrote:
> From: Adam Jackson <ajax at redhat.com>
> 
> Doing it as %(echo $HOME) means you'll fork a subshell every time you
> need the value of %_topdir, which is just wasteful.
> 
> Signed-off-by: Adam Jackson <ajax at redhat.com>
> ---
>  lib/rpmrc.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/rpmrc.c b/lib/rpmrc.c
> index 03d5dd1..9425a35 100644
> --- a/lib/rpmrc.c
> +++ b/lib/rpmrc.c
> @@ -450,6 +450,7 @@ export RPM_BUILD_ROOT\n}\
>  static void setDefaults(void)
>  {
>      const char *confdir = rpmConfigDir();
> +    chat *topdir;
char, not chat, surely?

(or is something up with my mailer?)



More information about the Rpm-maint mailing list