[Rpm-maint] [PATCH] Moved code to check possibility of freshen operation to checkFreshenStatus.

[Panu Matilainen]

On Wed, 11 Mar 2009, Rakesh Pandit wrote:

> Is checkFreshenStatus apt enough ?
>
> - Moved code to check possibility of freshen operation to 
> checkFreshenStatus.
>
> Patch: http://rakesh.fedorapeople.org/rpm/0002--Moved-code-to-check-possibility-of-freshen-operati.patch

Looks fine to me, just an enhancement suggestion while you're at this...
the "xx" is completely useless again as headerNVR() only ever returns with 
0, BUT checking for name != NULL would actually be appropriate:

headerNVR() failing here is pretty much a "cant happen" case, but if it 
somehow returned NULL in name, the following rpmtsInitIterator() would 
match every single package in the db and the checking would do completely 
bogus comparisons with unwanted results.

 	- Panu -