[Rpm-maint] [PATCH] Removed unnecessary rpmdbFreeIterator call ....

[Panu Matilainen]

On Fri, 13 Mar 2009, Rakesh Pandit wrote:

> I will factoring rpmgi.c specially rpmgiNext a bit and ripping not
> used parts. Aim being to ease it enough so that progress about
> "Conflict Updating thingy", Callback methods , manifest fixs can be
> made at later stage.
>
>
> - Removed unnecessary rpmdbFreeIterator call as rpmgiInitFilter
> already calls when NOT RPMRC_OK
> - Rearranged bit to keep the logic sane.
>
> Patch: http://rakesh.fedorapeople.org/rpm/0004--Removed-unnecessary-rpmdbFreeIterator-call-as-rpmg.patch

Hmm, rpmgiInitFilter() has:
         gi->mi = rpmdbFreeIterator(gi->mi);     /* XXX odd side effect? */

Looks to me like you could simply replace all the rpmdbFreeIterator() 
calls in rpmgiNext() and rpmgiInitFilter() by just one call at rpmgiNext() 
enditer: label, or am I missing some subtle little case? :)

 	- Panu -