[Rpm-maint] [PATCH] Removed unnecessary rpmdbFreeIterator call ....

[Rakesh Pandit]

2009/3/13 Panu Matilainen wrote:
> On Fri, 13 Mar 2009, Rakesh Pandit wrote:
>
[..]
>
> Hmm, rpmgiInitFilter() has:
>        gi->mi = rpmdbFreeIterator(gi->mi);     /* XXX odd side effect? */
>
> Looks to me like you could simply replace all the rpmdbFreeIterator() calls
> in rpmgiNext() and rpmgiInitFilter() by just one call at rpmgiNext()
> enditer: label, or am I missing some subtle little case? :)
>
>        - Panu -
>

Right. I missed it because I did not have a look at return rpmrc; just
above that label and though adding there would fail case for RPMRC_OK.

Updated:
http://rakesh.fedorapeople.org/rpm/0004--Removed-unnecessary-rpmdbFreeIterator-call-and-mov.patch

--
Regards,
Rakesh Pandit