[Rpm-maint] [PATCH] Add to the include path for misc dir

Panu Matilainen pmatilai at laiskiainen.org
Tue Oct 12 08:10:57 UTC 2010


On Tue, 12 Oct 2010, James M. Leddy wrote:

> Moving fts to util directory necessitates an additional include path in
> order for rpmutil.h to be found.
> ---
> misc/Makefile.am |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/misc/Makefile.am b/misc/Makefile.am
> index fcfea8c..2d0beac 100644
> --- a/misc/Makefile.am
> +++ b/misc/Makefile.am
> @@ -1,7 +1,7 @@
> # Makefile for misc library.
>
> -AM_CPPFLAGS = -I$(top_builddir) -I$(top_srcdir) -I$(top_builddir)/include/rpm
> -AM_CPPFLAGS += -I$(top_srcdir)/misc
> +AM_CPPFLAGS = -I$(top_builddir) -I$(top_srcdir) -I$(top_builddir)/include
> +AM_CPPFLAGS += -I$(top_builddir)/include/rpm -I$(top_srcdir)/misc
>
> EXTRA_DIST = \
> 	fnmatch.c	fnmatch.h \

Actually the only thing needed here is:
-AM_CPPFLAGS = -I$(top_builddir) -I$(top_srcdir) -I$(top_builddir)/include/rpm
+AM_CPPFLAGS = -I$(top_builddir) -I$(top_srcdir) -I$(top_builddir)/include

"-I$(top_builddir)/include/rpm" was just wrong there, probably a leftover 
from the big include-churn somewhere in 2007 but as nothing from misc/ has 
been including rpm headers it's gone unnoticed.

Fixed now in HEAD, thanks for pointing this out.

 	- Panu -





More information about the Rpm-maint mailing list